Re: Serial core dump on boot 2.4.0-test1-ac9

From: David Ford (david@kalifornia.com)
Date: Tue Jun 06 2000 - 23:19:51 EST


Almost, not quite. you have it backwards. "if (res->next)" should change to "if (!res ||
res->next)" which is my original patch, and the rest of the patch isn't needed.

-d

Richard Rager wrote:

> Thank you this work fine for me.
>
> Ok, I am going to say BUT, I updated to ac10 - the patch would not work
> so how about this patch for ac10. If I am off base tell me but I had to
> hand edit the file. This works after patch-2.4.0test1-ac10.gz
>
> Enjoy,
>
> Richard Rager
>
> --- linux.old/drivers/char/serial.c Tue Jun 6 23:55:45 2000
> +++ linux/drivers/char/serial.c Wed Jun 7 00:03:16 2000
> @@ -4904,13 +4904,12 @@
> !(check_compatible_id(dev)))
> return 1;
>
> - if (!res || res->next)
> + if (res->next)
> return 1;
>
> - for (resa = res->alt; resa; resa = resa->alt)
> - {
> - struct isapnp_port *port;
> - for (port = res->port; port; port = port->next)
> + for (resa = res->alt; resa; resa = resa->alt) {
> + struct isapnp_port *port;
> + for (port = res->port; port; port = port->next)
> if ((port->size == 8) &&
> ((port->min == 0x2f8) ||
> (port->min == 0x3f8) ||
>
> On Tue, 6 Jun 2000, David Ford wrote:
>
> > I've posted a patch for this three times now, Alan, please merge it.
> >
> > --- linux.old/drivers/char/serial.c Mon Jun 5 06:15:50 2000
> > +++ linux/drivers/char/serial.c Mon Jun 5 01:14:22 2000
> > @@ -4907,7 +4907,7 @@
> > !(check_compatible_id(dev)))
> > return 1;
> >
> > - if (res->next)
> > + if (!res || res->next)
> > return 1;
> >
> > for (resa = res->alt; resa; resa = resa->alt) {
> >
> > -d
> >
> >
> > Richard Rager wrote:
> >
> > > Ok this is my first posting so be nice ok?
> > >
> > > Ok went I add the
> > >
> > > CONFIG_SERIAL=y
> > >
> > > and this is what happen also by the way
> > >
> > > 2.4.0-test1 work find
> > >
> > > Serial driver version 5.01 (2000-05-29) with MANY_PORTS SHARE_IRQ SERIAL_PCI ISA PNP enabled
> > > ttyS00 at 0x03f8 (irq = 4) is a 16550A
> > > ttyS01 at 0x02f8 (irq = 3) is a 16550A
> > > ttyS02 at 0x03e8 (irq = 4) is a 16550A
> >

--
"The difference between 'involvement' and 'commitment' is like an
eggs-and-ham breakfast: the chicken was 'involved' - the pig was
'committed'."

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jun 07 2000 - 21:00:27 EST