[PATCH] Async I/O should indicate failure.

• Next message: Andrzej Krzysztofowicz: "Re: [PATCH] keybindings for xconfig,2.4.0-test1"
• Previous message: James Sutherland: "Re: Slow development cycle"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

If the fasync strategy fails (eg. ENOMEM from a tty), or is not
supported on that fd, the flag gets set anyway, and the user remains
unaware of failure.

I assume ENOTTY is correct here.

A similar (identical?) patch for 2.2 is required.

Rusty.
--- linux-2.3/fs/ioctl.c.~1~ Tue Nov 30 17:57:44 1999
+++ linux-2.3/fs/ioctl.c Tue Dec 21 14:10:54 1999
@@ -91,8 +91,12 @@
                         /* Did FASYNC state change ? */
                         if ((flag ^ filp->f_flags) & FASYNC) {
                                 if (filp->f_op && filp->f_op->fasync)
- filp->f_op->fasync(fd, filp, on);
+ error = filp->f_op->fasync(fd, filp, on);
+ else error = -ENOTTY;
                         }
+ if (error != 0)
+ break;
+
                         if (on)
                                 filp->f_flags |= FASYNC;
                         else

--
Hacking time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Andrzej Krzysztofowicz: "Re: [PATCH] keybindings for xconfig,2.4.0-test1"
• Previous message: James Sutherland: "Re: Slow development cycle"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:26 EST