Re: ReiserFS 3.6.6 is available

From: Alexander Viro (viro@math.psu.edu)
Date: Mon May 29 2000 - 12:19:06 EST


On Mon, 29 May 2000, Chris Mason wrote:

> > > Inside reiserfs_read_super, we have a failure path that calls
> > > dput(s->s_root). This looks ok to me, but please let me know if I'm
> > > missing something...
> >
> > Umm... It's harmless, but probably not needed - would be cleaned up
> > anyway.
>
> Ah, I missed the dput in kill_super....I'll remove the dput from our code.

Hey, you've said ->read_super()? In that case - yes, you _do_ need it.
Sorry about the braino. dput() is safe - no problem with that, just keep
in mind that it may block in some cases.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:21 EST