Re: epic100 && >=2.3.99pre7 && ping -f == reproducible lockup

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Sat May 27 2000 - 10:29:48 EST


Andrew Morton wrote:
>
> dart@iowaone.net wrote:
> >
> > 2.3.99pre6 works fine, >= pre7 is broken
> > 2.4.0-test1 is current kernel
> >
> > Eth is generally broken, no communication with other hosts whatsoever.
>
> Line 990, epic100.c:
>
> ep->dirty_tx = dirty_tx;
> if (ep->tx_full
> && cur_tx - dirty_tx < TX_RING_SIZE + 2) {
> /* The ring is no longer full, clear tbusy. */
> ep->tx_full = 0;
> netif_wake_queue(dev);
> }
>
> Methinks that should be 'TX_RING_SIZE - 2'

Good spotting, I'm not sure it should be 'TX_RING_SIZE -2' but it sure
looks like a bug. Donald, can you confirm? This is also in your latest
epic100.c...

        Jeff

-- 
Jeff Garzik              | Liberty is always dangerous, but
Building 1024            | it is the safest thing we have.
MandrakeSoft, Inc.       |      -- Harry Emerson Fosdick

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:17 EST