Re: [PATCH][2.3.99-pre9] arch/i386/config.in PM xconfig bug

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Wed May 24 2000 - 16:02:37 EST


Matthias Andree wrote:
>
> Hi,
>
> in the General Setup Menu, if Power Management is N, xconfig offers the
> suboptions of ACPI or APM. I identified the != "n" tests as problematic
> (since CONFIG_APM/ACPI are undefined/empty) and wrapped the entire
> section in a [ "$CONFIG_PM" != "n" ] to circumvent that problem.

Eliminate the "if" statements completely, and use dep_bool or dep_mbool
as necessary.

> It my perception of the problem is correct, so is my patch. Is there
> any CodingStyle as to the indention depth for config.in? My patch uses
> 2 characters indent.

3 characters indent -- code in Config.in
2 characters indent -- text contained within config.in options.

        Jeff

-- 
Jeff Garzik              | Liberty is always dangerous, but
Building 1024            | it is the safest thing we have.
MandrakeSoft, Inc.       |      -- Harry Emerson Fosdick

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:12 EST