Re: copy_mount_options in 2.3.99-pre9-pre3 and ncpmount (and others)

From: Manfred Spraul (manfreds@colorfullife.com)
Date: Mon May 22 2000 - 15:03:56 EST

Alan Cox wrote:
>
> > your change to copy_mount_option in 2.3.99-pre9-pre3 revealed that
> > copy_from_user does not work as expected :-( At least on ia32.
>
> This is true of 2.2 as well
>
> > which, unfortunately, checks sum of 'from + n' against
> > current->addr_limit.seg. And because of ncpmount passes some of
>
> This is correct. It would be too slow to check each byte,
>
Perhaps we should add the loop to copy_mount_options?

for(i=0;i<PAGE_SIZE;i++)
        if(get_user(kaddr++,uaddr++)
                break;

copy_mount_options isn't performance critical. 

--
	Manfred

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Tue May 23 2000 - 21:00:22 EST