Re: [PATCH]: PG_uptodate flag and read_cache_page()....

• Next message: Jeff Garzik: "Re: 2.2.15 with eepro100: eth0: Too much work at interrupt"
• Previous message: dmdaiko: "$B%2!<%`463P$G;O$a$i$l$kD64JC1%S($B%8%M%9( !"
• In reply to: Trond Myklebust: "[PATCH]: PG_uptodate flag and read_cache_page()...."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, 18 May 2000, Trond Myklebust wrote:
>
> The 'read_cache_page()' interface at the moment has a problem: If the
> page filler routine fails, then despite an ERR_PTR() being returned,
> the non-uptodate page is left in the page cache. Subsequent calls to
> read_cache_page() will then fail to retry to fill the page, because
> the current implementation is unaware of the PG_uptodate flag.

That's a bug.

I'd rather not introduce a new "fixed" version of read_cache_page() with a
new name, I'd _much_ rather just have a bug-fix to read_cache_page() that
realizes that just finding a page is not sufficient: even if the page is
found it must be up-to-date as well or the read needs to be re-tried.

Al, mind looking at this too (and yes, I'll get to the dentry stuff, I'm
just back from canada and trying to catch up with email. At least I
finally have DSL again ;)

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Jeff Garzik: "Re: 2.2.15 with eepro100: eth0: Too much work at interrupt"
• Previous message: dmdaiko: "$B%2!<%`463P$G;O$a$i$l$kD64JC1%S($B%8%M%9( !"
• In reply to: Trond Myklebust: "[PATCH]: PG_uptodate flag and read_cache_page()...."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue May 23 2000 - 21:00:19 EST