Re: [patch] Re: 2.2.16pre nls in 2.3?

From: Urban Widmark (urban@svenskatest.se)
Date: Sat May 20 2000 - 11:22:30 EST


On Sat, 20 May 2000, Alan Cox wrote:

> > int llen;
> > - nls->uni2char(ip[0], ip[1], op, 20, &llen);
> > + nls->uni2char(ip[1], ip[0], op, 20, &llen);
>
> Are you sure ?

No ... this uni1, uni2 stuff combined with 16bit unicode/x86 little endian
makes my head spin.

But it breaks in my testprogram. fs/fat/dir.c does it the other way
around. The first argument is ch (high?), the other cl (low?)

The unicode character 'A' is 0041 = 41 00 (on x86), with the patch the
arguments will be
  nls->uni2char(0x00, 0x41, op, 20, &llen);

this continues in the nls conversion as page_uni2charset[0x00], which I
believe is correct.

/Urban

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue May 23 2000 - 21:00:19 EST