Re: [linux-fbdev] Re: [PATCH] updated Mips Magnum frame buf

From: Petr Vandrovec (VANDROVE@vc.cvut.cz)
Date: Fri May 19 2000 - 04:33:59 EST


On 19 May 00 at 8:14, Geert Uytterhoeven wrote:
> On Thu, 18 May 2000, Petr Vandrovec wrote:
> > It does not... PROC_CONSOLE does NOT return current foreground console,
> > but tty of that process. Unless you are running fbset from process which
> > is not attached to tty, such as if you run fbset remote - in that case
> > it will control currently visible VT. But only in this case. And at least
> > I do run fbset locally, not remote.
> I really have to look at the original frame buffer device patches from Martin
> Schaller to see whether this was the intention of PROC_CONSOLE...
I have 2.0.38 fbmem.c from uClinux here (I wrote cyber5000 driver for it
in March; under NDA but if company will not crash, they'll release it -
- but what to do with driver for 2.0.38...) and it does:

static inline int PROC_CONSOEL(void)
{
   if (!current->tty)
        return fg_console;
   if (current->tty->driver.type != TTY_DRIVER_TYPE_CONSOLE)
        /* XXX Should report error here? */
        return fg_console;
   if (MINOR(current->tty->device) < 1)
        return fg_console;
   return MINOR(current->tty->device) - 1;
}

So I think that you are innocent and that this semantic is well established
since first fbdev releases (2.0.38 still uses old /dev/fb0current, ...)
                                                        Petr

                                                        

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue May 23 2000 - 21:00:17 EST