Erik Mouw writes:
> The only files that include linux/sound.h are sound drivers. Those
> sound drivers have to register themselves with the soundcore, and
> for that they need a struct file_operations. Therefore it's safe
> to include.
Which driver is this? It seems that the way this is handled by the
following files (which do use linux/sound.h) is to include linux/fs.h
first:
cmpci.o es1370.o es1371.o esssolo1.o
i810_audio.o maestro.o msnd.o sonicvibes.o
sound_config.h sound_core.o trident.o
Maybe you should do what all the other drivers do and include linux/fs.h
before linux/sound.h, by some means?
Are you sure that about 158 extra #include statements and associated
newlines for the C preprocessor and compiler is better than a simple
struct file_operations;
in linux/sound.h ?
_____
|_____| ------------------------------------------------- ---+---+-
| | Russell King rmk@arm.linux.org.uk --- ---
| | | | http://www.arm.linux.org.uk/~rmk/aboutme.html / / |
| +-+-+ --- -+-
/ | THE developer of ARM Linux |+| /|\
/ | | | --- |
+-+-+ ------------------------------------------------- /\\\ |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:22 EST