PATCH: Bug in invalidate_inode_pages()?

From: Juan J. Quintela (quintela@fi.udc.es)
Date: Mon May 08 2000 - 18:39:18 EST

Hi
        I think that I have found a bug in invalidate_inode_pages.
It results that we don't remove the pages from the
&inode->i_mapping->pages list, then when we return te do the next loop
through all the pages, we can try to free a page that we have freed in
the previous pass. Once here I have also removed the goto

Comments, have I lost something obvious?

Later, Juan.

diff -u -urN --exclude=CVS --exclude=*~ --exclude=.#* --exclude=TAGS pre7-6/mm/filemap.c testing2/mm/filemap.c
--- pre7-6/mm/filemap.c Fri May 5 23:58:56 2000
+++ testing2/mm/filemap.c Tue May 9 01:37:57 2000
@@ -121,6 +121,7 @@
                 /* We cannot invalidate a locked page */
                 if (TryLockPage(page))
                         continue;
+ list_del(curr);
                 spin_unlock(&pagecache_lock);
 
                 lru_cache_del(page); 

-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:12 EST