[PATCH] Fencepost error in devpts

• Next message: Doug McNaught: "Re: Hanging SCSI bus with Adaptec 2940U2W + Amptron PM-9600B"
• Previous message: BenHanokh Gabriel: "calling ext2fs function"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

There is a fencepost error in the devpts filesystem. The readdir function
never returns the entries with the number CONFIG_UNIX98_PTY_COUNT-1 and
CONFIG_UNIX98_PTY_COUNT-2, even if they exist.

--- fs/devpts/root.c.~1~ Tue May 2 17:26:05 2000
+++ fs/devpts/root.c Tue May 2 18:02:57 2000
@@ -66,5 +66,5 @@
                 /* fall through */
         default:
- while ( nr < sbi->max_ptys ) {
+ while ( nr - 2 < sbi->max_ptys ) {
                         int ptynr = nr - 2;
                         if ( sbi->inodes[ptynr] ) {

Andreas.

-- 
Andreas Schwab                                  "And now for something
SuSE Labs                                        completely different."
Andreas.Schwab@suse.de
SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Doug McNaught: "Re: Hanging SCSI bus with Adaptec 2940U2W + Amptron PM-9600B"
• Previous message: BenHanokh Gabriel: "calling ext2fs function"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:11 EST