2.3.51 on SPARC: Buglet in arch/sparc/kernel/sparc_ksyms.c

From: Horst von Brand (vonbrand@pincoya.inf.utfsm.cl)
Date: Tue Mar 14 2000 - 07:31:00 EST


The kernel won't compile with egcs-20000306, since EXPORT_SYMBOL_PRIVATE
tries to paste strings with ##. This is at least redundant in ANSI C, and
egcs-20000306 won't allow it:

--- arch/sparc/kernel/sparc_ksyms.c~ Thu Mar 9 11:57:17 2000
+++ arch/sparc/kernel/sparc_ksyms.c Tue Mar 14 08:13:34 2000
@@ -85,10 +85,10 @@
 __EXPORT_SYMBOL(__sparc_dot_ ## sym, "." #sym)
 
 #define EXPORT_SYMBOL_PRIVATE(sym) \
-extern int __sparc_priv_ ## sym (int) __asm__("__" ## #sym); \
+extern int __sparc_priv_ ## sym (int) __asm__("__" #sym); \
 const struct module_symbol __export_priv_##sym \
 __attribute__((section("__ksymtab"))) = \
-{ (unsigned long) &__sparc_priv_ ## sym, "__" ## #sym }
+{ (unsigned long) &__sparc_priv_ ## sym, "__" #sym }
 
 /* used by various drivers */
 EXPORT_SYMBOL(sparc_cpu_model);

-- 
Dr. Horst H. von Brand                       mailto:vonbrand@inf.utfsm.cl
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Mar 23 2000 - 21:00:16 EST