Scott Lampert wrote:
>
> I'm not sure who is supposed to get this or if I'm duplicating
> effort, but I just installed a new Netgear FA310TX 10/100 card with a
> revision -D2 board and I had to modify the tulip driver to recognize it.
> Its basically a Lite-On board with a different PCI vendor ID as far as I
> can tell. This was a 3 minute job so the driver will report any Lite-On
> card as a Netgear FA310TX with this patch because I just made the
> enumerations equal, but the vendor ID is there for the maintainer to fix
> it up so that it says the right thing for the right card if they like.
> I just needed this to work fast.
>
> It has a NGMC169 instead of the LC82C168 that the Lite-On in the
> tulip driver seems to have, but referencing the 2.0.x driver that comes
> with the Netgear card it seems to be coded to use the same code so I
> left well enough alone. ;) Especially since its probably out of my
> league to mess with it.
>
> Of note, the docs in the Netgear driver mention that the
> unmodified tulip 0.89 driver turns on store-and-forward and that their
> driver modifications turn it off for performance. Does the current
> 2.3.x tulip.c driver have it on by default as well?
>
> The attached patch is against 2.3.46.
When sending a patch to linux-kernel, you should consider running
finger @ftp.kernel.org
to make sure you are diffing against the latest version. In this case
you are a couple versions behind, so part of your patch now applies to
drivers/net/tulip/tulip.h and part of your patch applies to
drivers/net/tulip/tulip_core.c.
I've manually applied a slightly different version of your patch to my
local tree, and will send it off to Linus soon.
Also I find it good practice to CC also patches to linux-tulip too...
thanks for the patch!
Jeff
-- Jeff Garzik | Building 1024 | Viva la open source! MandrakeSoft, Inc. |- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Feb 29 2000 - 21:00:11 EST