Re: [patch] free_filps locking?

From: Manfred Spraul (manfreds@colorfullife.com)
Date: Wed Feb 23 2000 - 12:56:42 EST


Tim Waugh wrote:
>
> I've been looking at an oops that happened on 2.2.12-20smp (i386) on a
> four-processor SMP machine. It turns out that in remove_filp,
> file->f_next and file->f_pprev are both NULL.
>
> I wonder if it could be a race between insert_file_free and
> get_empty_filp, but it seems very odd that I'm the only one to see this
> race! Here's the patch I think might help (I haven't tried it yet):
>

This code should be protected by lock_kernel().

Do you use iBCS or any other unusual module? Perhaps a module doesn't
call lock_kernel().

--
	Manfred

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Feb 23 2000 - 21:00:34 EST