Re: [PATCH] 2.2 PPP driver SMP-safe

From: Manfred Spraul (manfreds@colorfullife.com)
Date: Sat Feb 19 2000 - 12:30:01 EST

Next message: Khimenko Victor: "Problems with IDE IRQ detection ?"
Previous message: Pavel Machek: "Re: Capabilities"
In reply to: Paul Mackerras: "[PATCH] 2.2 PPP driver SMP-safe"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Paul Mackerras wrote:
>
> The following patch should make the PPP driver in 2.2 SMP-safe.
>

I found the following function in the 2.3 syncPPP driver:

> static void
> ppp_sync_receive(struct tty_struct *tty, const unsigned char *buf,
> char *flags, int count)
> {
> struct syncppp *ap = tty->disc_data;
>
> if (ap == 0)
> return;
> trylock_recv_path(ap);
> ppp_sync_input(ap, buf, flags, count);

Is is guaranteed that the trylock_recv_path() will never fail, or is
that a typo? If this call cannot fail, please add a comment, or even
better a BUG(), or a FIXME.

-- Manfred

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/

Next message: Khimenko Victor: "Problems with IDE IRQ detection ?"
Previous message: Pavel Machek: "Re: Capabilities"
In reply to: Paul Mackerras: "[PATCH] 2.2 PPP driver SMP-safe"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Feb 23 2000 - 21:00:23 EST