Re: kfree_skb on hard IRQ warnings with kernel 2.3.47pre3 and starfire network driver

From: David S. Miller (davem@redhat.com)
Date: Fri Feb 18 2000 - 12:53:12 EST


Please try this patch:

--- drivers/net/starfire.c.~1~ Fri Feb 18 03:12:19 2000
+++ drivers/net/starfire.c Fri Feb 18 09:52:13 2000
@@ -962,7 +962,7 @@
                                                                          skb->len, PCI_DMA_TODEVICE);
 
                                         /* Scavenge the descriptor. */
- kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
                                         np->tx_info[entry].skb = NULL;
                                         np->tx_info[entry].mapping = 0;
                                         np->dirty_tx++;
@@ -1325,7 +1325,7 @@
                 np->rx_ring[i].rxaddr = cpu_to_le32(0xBADF00D0); /* An invalid address. */
                 if (np->rx_info[i].skb != NULL) {
                         pci_unmap_single(np->pdev, np->rx_info[i].mapping, np->rx_buf_sz, PCI_DMA_FROMDEVICE);
- kfree_skb(np->rx_info[i].skb);
+ dev_kfree_skb(np->rx_info[i].skb);
                 }
                 np->rx_info[i].skb = NULL;
                 np->rx_info[i].mapping = 0;
@@ -1336,7 +1336,7 @@
                         pci_unmap_single(np->pdev,
                                                          np->tx_info[i].mapping,
                                                          skb->len, PCI_DMA_TODEVICE);
- kfree_skb(skb);
+ dev_kfree_skb(skb);
                 }
                 np->tx_info[i].skb = NULL;
                 np->tx_info[i].mapping = 0;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Feb 23 2000 - 21:00:21 EST