Re: es1371 in 2.3.46

From: Thomas Sailer (sailer@ife.ee.ethz.ch)
Date: Thu Feb 17 2000 - 10:21:27 EST


Brad Campbell wrote:

> It appears to have a problem with the /dev/mixer interface
> as it crashes any mixer app I try to run.

The attached patch hopefully fixes this...

> Where to next.. I'm not proficient in C, but I'll take the
> time to do whatever it requires to solve the problem..
> Problem being, I don't know where to start...

First use dmesg. Then you'll see a kernel oops. Then use
ksymoops to decode the oops, then use find and grep to find
the source files which contain the functions listed in
the backtrace...

Tom

--- /usr/ife/t3/sailer/tmp4/linux-2.3.46/drivers/net/hamradio/hdlcdrv.c Tue Feb 15 20:45:00 2000
+++ drivers/net/hamradio/hdlcdrv.c Thu Feb 17 10:27:07 2000
@@ -381,11 +381,17 @@
                         if (pkt_len >= HDLCDRV_MAXFLEN || pkt_len < 2) {
                                 s->hdlctx.tx_state = 0;
                                 s->hdlctx.numflags = 1;
- dev_kfree_skb_irq(skb);
+ if (in_irq())
+ dev_kfree_skb_irq(skb);
+ else
+ dev_kfree_skb(skb);
                                 break;
                         }
                         memcpy(s->hdlctx.buffer, skb->data+1, pkt_len);
- dev_kfree_skb_irq(skb);
+ if (in_irq())
+ dev_kfree_skb_irq(skb);
+ else
+ dev_kfree_skb(skb);
                         s->hdlctx.bp = s->hdlctx.buffer;
                         append_crc_ccitt(s->hdlctx.buffer, pkt_len);
                         s->hdlctx.len = pkt_len+2; /* the appended CRC */
--- /usr/ife/t3/sailer/tmp4/linux-2.3.46/drivers/sound/esssolo1.c Tue Feb 15 20:45:28 2000
+++ drivers/sound/esssolo1.c Thu Feb 17 14:05:00 2000
@@ -2193,6 +2193,7 @@
 static int __devinit solo1_probe(struct pci_dev *pcidev, const struct pci_device_id *pciid)
 {
         struct solo1_state *s;
+ struct pm_dev *pmdev;
 
         if (!RSRCISIOREGION(pcidev, 0) ||
             !RSRCISIOREGION(pcidev, 1) ||
--- /usr/ife/t3/sailer/tmp4/linux-2.3.46/drivers/sound/ac97_codec.h Mon Feb 14 03:49:08 2000
+++ drivers/sound/ac97_codec.h Thu Feb 17 14:10:00 2000
@@ -107,13 +107,13 @@
 /* OSS interface to the ac97s.. */
 #define AC97_STEREO_MASK (SOUND_MASK_VOLUME|SOUND_MASK_PCM|\
         SOUND_MASK_LINE|SOUND_MASK_CD|\
- SOUND_MIXER_ALTPCM|SOUND_MASK_IGAIN|\
+ SOUND_MASK_ALTPCM|SOUND_MASK_IGAIN|\
         SOUND_MASK_LINE1|SOUND_MASK_VIDEO)
 
 #define AC97_SUPPORTED_MASK (AC97_STEREO_MASK | \
         SOUND_MASK_BASS|SOUND_MASK_TREBLE|\
         SOUND_MASK_SPEAKER|SOUND_MASK_MIC|\
- SOUND_MIXER_PHONEIN|SOUND_MIXER_PHONEOUT)
+ SOUND_MASK_PHONEIN|SOUND_MASK_PHONEOUT)
 
 #define AC97_RECORD_MASK (SOUND_MASK_MIC|\
         SOUND_MASK_CD|SOUND_MASK_VIDEO|\

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Feb 23 2000 - 21:00:20 EST