Hi,
You complained about KERN_ERR stuff but didn't notice duplicate return
-EINVAL :) (how did it get there?)
> +static struct file_operations microcode_fops = {
> + write: microcode_write,
> + open: microcode_open,
> + release: microcode_release,
> +};
>
> I'm guessing the above is a gcc extension to C of initializing a few
> members of a structure? It's slightly confusing, but a stylistic choice.
> (If it's standard C, I've never come across it before).
it is a standard, called New Linux Kernel Coding Standard :)
Didn't you know that after James Manning's patches were accepted, using
structure name tags is the preferred way?
Thanks for reviewing it - there is lots of cleanup. I will send it in
the next bunch to Linus. Also, I am adding support to update the size of
microcode file to num_cpu*2048 if update has taken place and fill it up
with arrays of struct microcode elements selected for update, i.e. one
can always check exactly what went into the CPUs.
Also, I need to make it devfs-aware.
Regards,
Tigran.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Feb 23 2000 - 21:00:19 EST