Re: PATCH 2.3.46: ll_rw_blk compile fixes

From: Andrea Arcangeli (andrea@suse.de)
Date: Thu Feb 17 2000 - 08:01:23 EST


On Wed, 16 Feb 2000, Jeff Garzik wrote:

>I also killed an possibly-uninit-var warning by setting
>__entry = NULL, [..]

__entry doesn't need to be initialized. I am not worried by the wrong gcc
complains.

> [..] and make generic_plug_device non-static
>because it is listed publicly in linux/blkdev.h.

There's no point in declaring it non static, if you need it simply don't
overwrite the function pointer with something else.

Andrea

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Feb 23 2000 - 21:00:18 EST