Re: dev->tx_timeout not being called in 2.3.4[345]

From: Linux Lists (lists@cyclades.com)
Date: Wed Feb 16 2000 - 12:30:47 EST


On Wed, 16 Feb 2000 kuznet@ms2.inr.ac.ru wrote:
>
> > if(dma_buf_write(card, ch, (ucchar *)skb->data, skb->len) != 0) {
> > netif_wake_queue(dev);
>
> Seems, it should be netif_stop_queue() yet?

No, in that case (in which there was a failure to write to the DMA TX
buffers), I'll discard that packet and restart the queue.

The thing is, as pointed out by Andi Kleen <ak@muc.de>, that I wans't
doing netif_stop_queue when the packet was successfully sent to the
hardware. Now everything is correct.

Anyhow, thanks for your answer!

Regards,
Ivan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Feb 23 2000 - 21:00:15 EST