Re: SCSI Makefile cleanup

From: willy@thepuffingroup.com
Date: Sun Feb 06 2000 - 15:09:28 EST


On Sun, Feb 06, 2000 at 06:41:19PM +0000, Alan Cox wrote:
> > This patch reworks drivers/scsi/Makefile to use lists instead of
> > conditionals. I believe this idea is originally due to Michael Chastain.
>
> Be very careful not to change the link order. You'll notice 2.3.x sound
> recently changed a little explicitly because of this. if you re-order
> the object files (eg sorting them) then you change the init order, and you
> end up initialising boards in the wrong order, causing AHA1542 to grab
> buslogic cards etc

Oh, drat. I didn't reorder the lines in the file, but I did then use
$(sort $(obj_y)) to remove duplicates. I don't think duplicates really
matter, it was just an optimisation. If that sort is removed, how does
it look?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Feb 07 2000 - 21:00:13 EST