msync() on NFS still broken in 2.3.40, patch still fixes

From: Jim Studt (jim@federated.com)
Date: Sat Jan 22 2000 - 18:11:41 EST


I just checked msync() on NFS on a 2.3.40 i386 machine, it is still broken.
nfs_writepage is returning PAGE_SIZE on success instead of 0.

This patch to fs/nfs/write.c fixes it...

--- write.c~ Wed Dec 15 17:24:12 1999
+++ write.c Sat Jan 22 16:28:07 2000
@@ -416,7 +416,9 @@
 int
 nfs_writepage(struct dentry * dentry, struct page *page)
 {
- return nfs_writepage_sync(dentry, dentry->d_inode, page, 0, PAGE_SIZE);
+ int result = nfs_writepage_sync(dentry, dentry->d_inode, page, 0, PAGE_SIZE);
+ if ( result == PAGE_SIZE) return 0;
+ return result;
 }
 
 /*

-- 
                                     Jim Studt, President
                                     The Federated Software Group, Inc.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jan 23 2000 - 21:00:28 EST