Re: [Patch] Cleanup struct gendisk registration, 2.3.40-pre1

From: Alexander Viro (aviro@redhat.com)
Date: Sun Jan 16 2000 - 22:01:16 EST


On Mon, 17 Jan 2000, Alan Cox wrote:

> > == you need the first sector. And I don't think that we really have to go
> > through ll_rw_blk here - we are in the driver, after all, so we shouldn't
> > need anything fancy to feed request to the disk, no?
>
> I need to generate a request block. Doing anything but putting a request
> on the queues would add special cases to the main code paths. Not on. So
> I might as well use ll_rw_blk

<shrug> fine, but I'm less than sure that ll_rw_blk() is the right path -
both for that and for fs/partitions/*. The reason being: ll_rw_blk() does
checking for block size. When we are doing partition reading we have all
buffer_heads dropped and we want to drop the buffer_heads generated in
process of parsing. So I'ld rather have a version of ll_rw_blk() that
would have 512-bytes granularity and ignored the block sizes. Would
simplify the stuff on revalidate() - we are playing interesting games
with setting block size there... Anyway, it's Not For Now(tm).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jan 23 2000 - 21:00:14 EST