Re: [Patch] Cleanup struct gendisk registration, 2.3.40-pre1

From: Alexander Viro (aviro@redhat.com)
Date: Thu Jan 13 2000 - 21:06:59 EST


On Thu, 13 Jan 2000, Linus Torvalds wrote:

> On Thu, 13 Jan 2000, Alexander Viro wrote:
> >
> > Ob_gendisk(): Linus, why on the earth do we have this ->init() thing
> > there? It should be called from driver initialization code instead of the
> > middle of partition_setup(). Modules are calling it directly anyway,
> > conditions wrt interrupts are same, so what's the reason for postponing
> > the thing? IOW, will you accept moving the call to initialization and
> > removing gendisk.init?
>
> Yes. But I'm getting worried about too many changes now. The patch from
> Stephen looked ok, although his new /proc interface wasn't, and I don't
> understand the point of having a separate program to parse /proc. If it
> isn't readable already, then why?
>
> I'm making a new pre-patch.

OK, could somebody explain where does IDE call ide_geninit() if built as
module? And if it (apparently) doesn't, do we need it in built-in case?
Andre, could you comment on that?
                                                        Cheers,
                                                                Al

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:24 EST