request_module rehash

From: James Manning (jmm@raleigh.ibm.com)
Date: Thu Jan 13 2000 - 14:49:52 EST


I was thinking about the cases where request_module's return
isn't checked... isn't this broken code and the calling code
should be checking < 0 and return'ing -ENODEV (or similar)?

Yes, it seems at least to a small extent rampant to request_module
and assume it works, but the more I think about it, those calls
should get fixed as they are broken code.

In this light, the macro approach is nice as the compiler warnings
help highlight these pieces of broken code so they can be fixed.

Thoughts?

James

-- 
Miscellaneous Engineer --- IBM Netfinity Performance Development

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:23 EST