Re: [PATCH] Replacing __SMP__ by CONFIG_SMP globally in linux-2.3.39.

From: Niels Kristian Bech Jensen (nkbj@image.dk)
Date: Wed Jan 12 2000 - 12:51:15 EST


On Wed, 12 Jan 2000, Richard B. Johnson wrote:

> What is its purpose? __SMP__ is not just defined or not defined from
> the linux kernel source directory, but also used for writing modules
> which, in fact, may not exist within the kernel source directory at
> all.
>
> So, if such a patch goes into the kernel, module makefiles now have
> to be modified to define "CONFIG_SMP" instead of "__SMP__" which,
> since they may not even have a "configuration", becomes just another
> PITA to support "change for the sake of change".
>
The purpose is to get rid of what I consider an ugly hack. Since
CONFIG_SMP is a proper config option, it and only it should be used IMHO.
What is the purpose of having a config option symbol (CONFIG_SMP) define
another symbol (__SMP__) ?

External modules built for SMP kernels should already define CONFIG_SMP if
they use any header files from the kernel, as CONFIG_SMP is used by some
files under the linux/include directory. The change is that they don't
need to define both __SMP__ and CONFIG_SMP.

-- 
Niels Kristian Bech Jensen -- nkbj@image.dk -- http://www.image.dk/~nkbj/

----------->> Stop software piracy --- use free software! <<-----------

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:20 EST