On Tue, 11 Jan 2000, Thomas Schenk wrote:
> On Sun, Jan 09, 2000 at 07:21:04AM -0800, Tigran Aivazian wrote:
> > Hi Linus,
> >
> > The patch is against 2.3.39-pre1, I have not checked if it has been fixed
> > in pre2 already (hope not).
> >
>
> Is this bug also in the 2.2.x driver?
>
Strictly speaking yes. Well spotted (I never look at 2.2.x, sorry :)
It is not triggered because the spinlock magic debug code is not active by
default.
Here is the patch for 2.2.14 (cc'd Alan)
Regards,
Tigran.
--- 3c509.c.0 Wed Jan 12 08:01:48 2000
+++ 3c509.c Wed Jan 12 08:02:14 2000
@@ -374,6 +374,7 @@
((struct el3_private *)dev->priv)->mca_slot = mca_slot;
((struct el3_private *)dev->priv)->next_dev = el3_root_dev;
+ ((struct el3_private *)dev->priv)->lock = (spinlock_t) SPIN_LOCK_UNLOCKED;
el3_root_dev = dev;
if (el3_debug > 0)
@@ -433,9 +434,6 @@
outw(TxReset, ioaddr + EL3_CMD);
outw(RxReset, ioaddr + EL3_CMD);
outw(SetStatusEnb | 0x00, ioaddr + EL3_CMD);
-
- /* Set the spinlock before grabbing IRQ! */
- ((struct el3_private *)dev->priv)->lock = (spinlock_t) SPIN_LOCK_UNLOCKED;
if (request_irq(dev->irq, &el3_interrupt, 0, dev->name, dev)) {
return -EAGAIN;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:19 EST