Re: [PATCH] fb.h cleanup

From: Geert Uytterhoeven (Geert.Uytterhoeven@sonycom.com)
Date: Tue Jan 11 2000 - 02:37:35 EST


On Tue, 11 Jan 2000, Erik Andersen wrote:
> On Tue Jan 11, 2000 at 08:24:28AM +0100, Geert Uytterhoeven wrote:
> > On Mon, 10 Jan 2000, Erik Andersen wrote:
> > > On Mon Jan 10, 2000 at 09:55:32AM +0100, Geert Uytterhoeven wrote:
> > > > On Sun, 9 Jan 2000, James A Simmons wrote:
> > > > > Please test this patch. It's against a pre-2.3.39-2. Once you are happy
> > > > > with it Geert can you send it to linus. Thank you.
> > > >
> > > > > -#define FBIOGET_VSCREENINFO 0x4600
> > > > > +#define FBIOGET_VSCREENINFO _IOWR(FB_IOC_MAGIC, 0, struct fb_var_screeninfo)
> > > >
> > > > Are these backwards compatible on all platforms?
> > >
> > > Does it matter? From user space you already have to do a
> > >
> > > #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,2,0)
> > > foo
> > > #else
> > > bar
> > > #endif
> > >
> > > since things like struct fb_var_screeninfo already
> > > had its internals changed.
> >
> > No you don't. All changes until now were backwards compatible.
> >
>
> Not this one.
>
> In 2.0.x:
> struct fb_var_screeninfo {
> ...
> int accel; /* see FB_ACCEL_* */
> ...
> }
>
> In 2.2.x:
> struct fb_var_screeninfo {
> ...
> __u32 accel_flags; /* acceleration flags (hints) */
> ...
> }

In theory not. But var.accel wasn't used before.

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven ----------------- Sony Suprastructure Center Europe (SUPC-E)
Geert.Uytterhoeven@sonycom.com ------------------- Sint-Stevens-Woluwestraat 55
Voice +32-2-7248632 Fax +32-2-7262686 ---------------- B-1130 Brussels, Belgium

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:17 EST