Re: [PATCH 3/4] clk: qcom: Add support for Display Clock Controller on Shikra

From: Konrad Dybcio

Date: Wed May 13 2026 - 10:52:50 EST


On 5/13/26 4:06 PM, Dmitry Baryshkov wrote:
> On Wed, May 13, 2026 at 05:01:16PM +0300, Dmitry Baryshkov wrote:
>> On Wed, May 13, 2026 at 07:10:38PM +0530, Imran Shaik wrote:
>>> Add a driver for the Display clock controller on Qualcomm Shikra SoC.
>>>
>>> Signed-off-by: Imran Shaik <imran.shaik@xxxxxxxxxxxxxxxx>
>>> ---
>>> drivers/clk/qcom/Kconfig | 10 +
>>> drivers/clk/qcom/Makefile | 1 +
>>> drivers/clk/qcom/dispcc-shikra.c | 565 +++++++++++++++++++++++++++++++++++++++
>>> 3 files changed, 576 insertions(+)
>>>
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>
> After comparing the files...
>
> Can we use dispcc-qcm2290.c instead? It uses clock-names instead of
> clock-indices, but I think it should be fine to use clock-names as a
> one-off.

Or we can convert it to use indices, since those are stable for agatti
too - the names would remain in the binding, just unused by the driver

Konrad