Re: [PATCH v2] staging: iio: addac: adt7316: document SPI interface switching sequence

From: Andy Shevchenko

Date: Sun May 10 2026 - 04:55:28 EST


On Sun, May 10, 2026 at 08:10:41AM +0000, Hungyu Lin wrote:
> The device powers up in I2C mode. Switching to SPI mode
> requires sending a sequence of SPI writes as described in
> the datasheet.
>
> During this sequence, the device may still be in I2C mode,
> so SPI transactions may not be recognized and can fail.
> Such errors are expected and are ignored.
>
> Add a comment to clarify this behavior.

...

> Changes in v2:
> - Add datasheet reference

This is still odd. Please, put in a format

$SNUM "$STITLE"

where $SNUM is the section number (like 2.1.4) and "$STITLE" as currently done
in this version, Ideally the datasheet also needs a versioning.

...

With that being addressed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

--
With Best Regards,
Andy Shevchenko