Re: [PATCH v6 0/8] staging: rtl8723bs: rtw_mlme: fix long lines and related issues

[Luka Gejak]

On April 28, 2026 6:44:30 PM GMT+02:00, Salman Alghamdi <me@xxxxxxxxxxxx> wrote:
>This series addresses review feedback on v5. Changes from v5:
>
>- Fix variable declaration ordering that broke compilation due to
>  dependency on uninitialized pointer (per Luka Gejak)
>
>Salman Alghamdi (8):
>  staging: rtl8723bs: fix buffer over-read in rtw_update_protection
>  staging: rtl8723bs: rtw_mlme: add bounds checks before ie_length
>    subtraction
>  staging: rtl8723bs: rtw_mlme: wrap lines exceeding 100 columns
>  staging: rtl8723bs: rtw_mlme: wrap rtw_sitesurvey_cmd condition
>  staging: rtl8723bs: rtw_mlme: extract local variables for long
>    expressions
>  staging: rtl8723bs: rtw_mlme: remove dead commented-out code
>  staging: rtl8723bs: rtw_mlme: consolidate capability comparisons lines
>  staging: rtl8723bs: rtw_mlme: add blank line for readability
>
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 276 ++++++++++++++--------
> 1 file changed, 183 insertions(+), 93 deletions(-)
>

LGTM, so unless Dan has something to add, for the patch series:

Reviewed-by: Luka Gejak <luka.gejak@xxxxxxxxx>

Best regards,
Luka Gejak