Re: [PATCH v6 1/2] dt-bindings: pwm: dwc: add optional reset

From: Krzysztof Kozlowski

Date: Tue Apr 28 2026 - 05:42:32 EST


On 28/04/2026 11:30, Xuyang Dong wrote:
>>>
>>> +allOf:
>>> + - $ref: pwm.yaml#
>>> +
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: eswin,eic7700-pwm
>>
>> Same problem as v3 which I commented. I do not understand why your new
>> device has also 1 reset.
>>
>> Your commit msg MUST explain why 1 reset is valid.
>>
>
> Hi Krzysztof,
>
> Although the PWM IP supports two clock domains, each requiring a reset, 
> the EIC7700 implementation uses the same clock domain for both clock 
> signals. Therefore, the eic7700-pwm only supports one reset.
>

If we speak about eic7700, explain why it has two resets now, according
to schema, even though you say it has not.

But I was speaking about dw-apb-timers-pwm, which has one reset as well!
Why you are not having proper constraints? Please read writing bindings
document.

Best regards,
Krzysztof