[PATCH v3 2/2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add in dsi probe
From: Osama Abdelkader
Date: Thu Apr 23 2026 - 16:06:34 EST
Use devm_drm_bridge_add() so the bridge is released if probe fails after
registration, and drop drm_bridge_remove() in chipone_dsi_probe.
Signed-off-by: Osama Abdelkader <osama.abdelkader@xxxxxxxxx>
---
v3: split the patch into two, one for i2c probe (bugfix) and one for dsi probe
v2: devm_drm_bridge_add instead of drm_bridge_add
---
drivers/gpu/drm/bridge/chipone-icn6211.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index 4d76e1bd5e78..f53e64129ebe 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -730,13 +730,11 @@ static int chipone_dsi_probe(struct mipi_dsi_device *dsi)
mipi_dsi_set_drvdata(dsi, icn);
- drm_bridge_add(&icn->bridge);
-
- ret = chipone_dsi_attach(icn);
+ ret = devm_drm_bridge_add(dev, &icn->bridge);
if (ret)
- drm_bridge_remove(&icn->bridge);
+ return ret;
- return ret;
+ return chipone_dsi_attach(icn);
}
static int chipone_i2c_probe(struct i2c_client *client)
--
2.43.0