Re: [PATCH v2 1/5] dt-bindings: leds: Document TI LM3560 Synchronous Boost Flash Driver
From: Svyatoslav Ryhel
Date: Wed Apr 22 2026 - 02:37:11 EST
пн, 20 квіт. 2026 р. о 19:38 Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> пише:
>
> Hi Conor,
>
> On Mon, Apr 20, 2026 at 05:20:28PM +0100, Conor Dooley wrote:
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + - ti,lm3559
> > > + - ti,lm3560
> >
> > What differentiates these devices to the point that fallback compatibles
> > are not suitable?
>
> Good question.
>
> It seems the currents are different albeit the register values themselves
> are the same. The driver doesn't seem to handle that properly right now, so
> it's a driver bug.
>
> I'd keep the compatibles as-is as the current limit applied should be as
> specified in DT.
>
This is a valid point. Unfortunately, I don't have device with lm3559
to adjust driver accordingly and test.
So, Conor, Sakari, what changes if any I should apply here in v3?
> --
> Kind regards,
>
> Sakari Ailus