Re: [PATCH v4 16/24] x86/virt/seamldr: Install a new TDX Module
From: Xu Yilun
Date: Wed Mar 04 2026 - 23:43:31 EST
> > -static int do_seamldr_install_module(void *params)
> > +static int do_seamldr_install_module(void *seamldr_params)
>
> Nit:
>
> IMHO such renaming is just a noise to this patch, since in patch 10/11 it's
Agree. Otherwise
Reviewed-by: Xu Yilun <yilun.xu@xxxxxxxxxxxxxxx>
> clear that the 'params' you passed in is seamldr_params. No?
>
> Perhaps just name it 'seamldr_params' at patch 11?