Re: [PATCH net-next v4 5/8] net: dsa: microchip: Add KSZ8463 tail tag handling

[Bastien Curutchet]

Hi Jakub,

On 1/30/26 5:15 AM, Jakub Kicinski wrote:
> Sorry for the nit but:
>
> On Tue, 27 Jan 2026 10:06:47 +0100 Bastien Curutchet (Schneider
> Electric) wrote:
> >   	case DSA_TAG_PROTO_KSZ9893:
> >   	case DSA_TAG_PROTO_KSZ9477:
> > +	case DSA_TAG_PROTO_KSZ8463:
> >   	case DSA_TAG_PROTO_LAN937X:
>
> This..
>
> >   #define KSZ9477_NAME "ksz9477"
> >   #define KSZ9893_NAME "ksz9893"
> >   #define LAN937X_NAME "lan937x"
> > +#define KSZ8463_NAME "ksz8463"
>
> this
>
> > @@ -457,6 +526,7 @@ static struct dsa_tag_driver *dsa_tag_driver_array[] = {
> >   	&DSA_TAG_DRIVER_NAME(ksz9477_netdev_ops),
> >   	&DSA_TAG_DRIVER_NAME(ksz9893_netdev_ops),
> >   	&DSA_TAG_DRIVER_NAME(lan937x_netdev_ops),
> > +	&DSA_TAG_DRIVER_NAME(ksz8463_netdev_ops),
>
> and this - appear to have been alphabetically sorted previously, now
> we're just adding at the end.


Good catch, I'll fix this in next iteration (once net-next re-opens).


Best regards,
Bastien