Re: [PATCH V4 3/4] dt-bindings: media: ti: vpe: Add support for Video Input Port

From: Krzysztof Kozlowski

Date: Tue Oct 21 2025 - 02:46:21 EST


On Wed, Oct 15, 2025 at 11:10:09AM +0530, Yemike Abhilash Chandra wrote:
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + vip1: video@48970000 {

Drop label, while at it.

> + compatible = "ti,dra7-vip";
> + reg = <0x48970000 0x1000>;
> + interrupts = <GIC_SPI 351 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 392 IRQ_TYPE_LEVEL_HIGH>;
> + ti,ctrl-module = <&scm_conf 0x534 0x0 0x2 0x1 0x3>;
> +
> + ports {
> + #address-cells = <1>;

You still have completely messed up indentation.

> + #size-cells = <0>;
> +
> + vin1a: port@0 {
> + reg = <0>;
> +
> + vin1a_ep: endpoint {

Best regards,
Krzysztof