Re: [PATCH 2/9] dt-bindings: clock: google,gs101-clock: add samsung,sysreg property as required

[Krzysztof Kozlowski]

On 13/10/2025 22:51, Peter Griffin wrote:
> Update the bindings documentation so that all CMUs (with the exception of
> gs101-cmu-top) have samsung,sysreg as a required property.


Why? You described the patch contents, which I can see. I don't
understand why we need it, especially that this is ABI break.

> 
> Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> ---
>  .../bindings/clock/google,gs101-clock.yaml         | 23 +++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> index caf442ead24bda57e531420d8a7d8de8713032ae..5cfe98d9ba895d5207fffc82f3fd55b602b4a2bb 100644
> --- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> @@ -49,6 +49,11 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  samsung,sysreg:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to system registers interface.


Your description should say here: for what purpose, how this device is
going to use it.

> +
>  required:
>    - compatible
>    - "#clock-cells"
> @@ -163,6 +168,22 @@ allOf:
>              - const: bus
>              - const: ip
Best regards,
Krzysztof