Re: [PATCH net] net: phy: micrel: always set shared->phydev for LAN8814

[Horatiu Vultur]

The 10/21/2025 15:32, Andrew Lunn wrote:

Hi,

> 
> On Tue, Oct 21, 2025 at 03:20:26PM +0200, Robert Marko wrote:
> > Currently, during the LAN8814 PTP probe shared->phydev is only set if PTP
> > clock gets actually set, otherwise the function will return before setting
> > it.
> >
> > This is an issue as shared->phydev is unconditionally being used when IRQ
> > is being handled, especially in lan8814_gpio_process_cap and since it was
> > not set it will cause a NULL pointer exception and crash the kernel.
> >
> > So, simply always set shared->phydev to avoid the NULL pointer exception.
> >
> > Fixes: b3f1a08fcf0d ("net: phy: micrel: Add support for PTP_PF_EXTTS for lan8814")
> > Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>
> 
> Please could you look at how this patch and
> 
> [PATCH net-next v2] net: phy: micrel: Add support for non PTP SKUs for lan8814
> 
> work together. It might be this patch is not required because of
> changes in that patch?

I managed to reproduce this issue also with the patch:

[PATCH net-next v2] net: phy: micrel: Add support for non PTP SKUs for lan8814

The way I reproduced the issue is by disabling the config PTP_1588_CLOCK
and then just set the port up to get an interrupt.
Then I try to apply this patch and then the issue was fixed.

Tested-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>

> 
> Thanks
>         Andrew

-- 
/Horatiu