Re: [PATCH 1/2] nvme-pci: Print error message on failure in nvme_probe

From: Greg Kroah-Hartman

Date: Wed Oct 22 2025 - 03:48:42 EST


On Wed, Oct 22, 2025 at 08:26:34AM +0200, Christoph Hellwig wrote:
> On Mon, Oct 20, 2025 at 05:29:07PM +0200, Gerd Bayer wrote:
> > Add a new error message like
> > nvme nvme0: probe failed on 2004:00:00.0 (result: -19)
> > that makes failures to probe visible in the kernel log.
>
> Is that really a thing drivers are expected to do? If it is generally
> usefull I'd expect it to be in the driver core.

We have that already, dev_err_probe(), no need to create
yet-another-version of that.

thanks,

greg k-h