Re: [PATCH net 1/2] selftests: netconsole: Add race condition test for userdata corruption

[Gustavo Luiz Duarte]

On Mon, Oct 20, 2025 at 8:14 PM Andre Carvalho <asantostc@xxxxxxxxx> wrote:
>
> Hi Gustavo,
>
> On Mon, Oct 20, 2025 at 02:22:34PM -0700, Gustavo Luiz Duarte wrote:
> > This test validates the fix for potential race conditions in the
> > netconsole userdata path and serves as a regression test to prevent
> > similar issues in the future.
>
> I noticed the test was not added to the TEST_PROGS in the Makefile like other
> selftests. Is that intentional?
>
> You might also need to change the order of the patches in the series to
> make sure the test passes in CI.
>
> > +cleanup_children() {
> > +     pkill_socat
> > +     # Remove the namespace, interfaces and netconsole target
> > +     cleanup
> > +     kill $child1 $child2 2> /dev/null || true
> > +     wait $child1 $child2 2> /dev/null || true
> > +}
>
> Calling cleanup before stopping loop_set_userdata causes writing the userdata to
> fail. You might want to move the kill and wait lines to before call to cleanup.
> Additionally, shellcheck also suggests wrapping $child1 and $child2 with double
> quotes.

Thanks for reviewing, Andre! I'm sending v2 with your suggestions.