Re: [PATCH v5 1/3] dt-bindings: display/msm: Add SM6150 DisplayPort controller

[Dmitry Baryshkov]

On 23/10/2025 07:50, Xiangxu Yin wrote:
> On 10/22/2025 11:07 PM, Dmitry Baryshkov wrote:
> > On Tue, Oct 21, 2025 at 11:18:07AM +0800, Xiangxu Yin via B4 Relay wrote:
> > > From: Xiangxu Yin <xiangxu.yin@xxxxxxxxxxxxxxxx>
> > >
> > > SM6150 uses the same DisplayPort controller as SM8150, which is already
> > > compatible with SM8350. Add the SM6150-specific compatible string and
> > > update the binding example accordingly.
> > >
> > > Signed-off-by: Xiangxu Yin <xiangxu.yin@xxxxxxxxxxxxxxxx>
> > > ---
> > >   .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml   | 13 ++++++++++++-
> > >   1 file changed, 12 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
> > > index 9ac24f99d3ada1c197c9654dc9babebccae972ed..89852af70de97a9025079107b838de578778c049 100644
> > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
> > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml
> > > @@ -51,6 +51,16 @@ patternProperties:
> > >         compatible:
> > >           const: qcom,sm6150-dpu
> > >   
> > > +  "^displayport-controller@[0-9a-f]+$":
> > > +    type: object
> > > +    additionalProperties: true
> > > +    properties:
> > > +      compatible:
> > > +        items:
> > > +          - const: qcom,sm6150-dp
> > > +          - const: qcom,sm8150-dp
> > > +          - const: qcom,sm8350-dp
> > > +
> > >     "^dsi@[0-9a-f]+$":
> > >       type: object
> > >       additionalProperties: true
> > > @@ -132,13 +142,14 @@ examples:
> > >                   port@0 {
> > >                     reg = <0>;
> > >                     dpu_intf0_out: endpoint {
> > > +                    remote-endpoint = <&mdss_dp0_in>;
> > Why?
>
>
> Oh, I think I misunderstood the “messed up indentation” comment from Krzysztof.
> It seems the two-space indentation under port@X and opp-x is the actual issue.
>
> However, that part was not introduced in this patch.
> I will split a separate patch to fix the indentation there.

Note, you have two different chunks here. The first one is useless as it 
adds a graph arc to a node that is not a part of the example.

> > >                     };
> > >                   };
> > >   
> > >                   port@1 {
> > >                     reg = <1>;
> > >                     dpu_intf1_out: endpoint {
> > > -                      remote-endpoint = <&mdss_dsi0_in>;
> > > +                    remote-endpoint = <&mdss_dsi0_in>;
> > Why?
>
>
> Ack.

Use YAML coding style (two-space indentation). For DTS examples in the 
schema, preferred is four-space indentation.


--
With best wishes
Dmitry