Re: [PATCH v1] mfd: max77705: support revision 0x2

[Eric Gonçalves]

On October 23, 2025 11:21:44 AM GMT-03:00, Lee Jones <lee@xxxxxxxxxx> wrote:
>On Thu, 23 Oct 2025, Ghatto wrote:
>
>> On Thu, Oct 23, 2025 at 10:17 AM Lee Jones <lee@xxxxxxxxxx> wrote:
>> >
>> > On Tue, 14 Oct 2025, Eric Gonçalves wrote:
>> >
>> > > Revision 0x2 has been tested on the r0q (Galaxy S22) board.
>> > >
>> > > Signed-off-by: Eric Gonçalves <ghatto404@xxxxxxxxx>
>> > > ---
>> > >  drivers/mfd/max77705.c | 4 ++--
>> > >  1 file changed, 2 insertions(+), 2 deletions(-)
>> > >
>> > > diff --git a/drivers/mfd/max77705.c b/drivers/mfd/max77705.c
>> > > index e1a9bfd65856..5201a4c9c3f5 100644
>> > > --- a/drivers/mfd/max77705.c
>> > > +++ b/drivers/mfd/max77705.c
>> > > @@ -105,8 +105,8 @@ static int max77705_i2c_probe(struct i2c_client *i2c)
>> > >               return -ENODEV;
>> > >
>> > >       pmic_rev = pmic_rev_value & MAX77705_REVISION_MASK;
>> > > -     if (pmic_rev != MAX77705_PASS3)
>> > > -             return dev_err_probe(dev, -ENODEV, "Rev.0x%x is not tested\n", pmic_rev);
>> > > +     if (pmic_rev == MAX77705_PASS1)
>> > > +             return dev_err_probe(dev, -ENODEV, "Rev.0x1 is not tested\n");
>> >
>> > What happens when PASS4 is released but not tested?
>> PASS4 doesn't exist from what I've seen on the max77705 header files.
>
>Not yet.
>
>But not having it in the defined does not mean one won't exist in the future.
I don't think it will, newer Samsungs already use a new maxim controller.
>