Re: [PATCH 2/2] wifi: WQ_PERCPU added to alloc_workqueue users

[Johannes Berg]

Hi,

So I don't know if I really need to tell you this, but generally the
subject should be _imperative_, not describing what you did after the
fact (i.e. "add WQ_PERCPU to ..." rather than "added ...")

> All existing users have been updated accordingly.

Surely this is not _all_ existing users? :)

> Suggested-by: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Marco Crivellari <marco.crivellari@xxxxxxxx>
> ---
>  drivers/net/wireless/ath/ath6kl/usb.c         | 2 +-
>  drivers/net/wireless/quantenna/qtnfmac/core.c | 3 ++-
>  drivers/net/wireless/realtek/rtlwifi/base.c   | 2 +-
>  drivers/net/wireless/realtek/rtw88/usb.c      | 3 ++-
>  drivers/net/wireless/silabs/wfx/main.c        | 2 +-
>  drivers/net/wireless/st/cw1200/bh.c           | 4 ++--

These have different maintainers, please split up accordingly.

>  6 files changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c
> index 38bb501fc553..bfb21725d779 100644
> --- a/drivers/net/wireless/ath/ath6kl/usb.c
> +++ b/drivers/net/wireless/ath/ath6kl/usb.c
> @@ -637,7 +637,7 @@ static struct ath6kl_usb *ath6kl_usb_create(struct usb_interface *interface)
>  	ar_usb = kzalloc(sizeof(struct ath6kl_usb), GFP_KERNEL);
>  	if (ar_usb == NULL)
>  		return NULL;
> -	ar_usb->wq = alloc_workqueue("ath6kl_wq", 0, 0);
> +	ar_usb->wq = alloc_workqueue("ath6kl_wq", WQ_PERCPU, 0);
>  	if (!ar_usb->wq) {
>  		kfree(ar_usb);

I'd also think that WQ_PERCPU doesn't actually make sense for any of
these instances, but for those that still have an active maintainer I'll
defer to them, of course.


(and patch 1 should be prefixed with "wifi: cfg80211:" I'd think)

johannes