Re: [PATCH v3 1/3] arm64: dts: nuvoton: fix warning and nodes order

[Krzysztof Kozlowski]

On 25/09/2025 22:06, Tomer Maimon wrote:
> Fix the warning in the gcr and timer nodes, and modify nodes order by

What warning?

> ascending unit address.

Why are you combining multiple issues into one commit. No. Read
submitting patches how to organize your work.

> 
> Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx>
> ---
>  .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 35 +++++++++----------
>  1 file changed, 17 insertions(+), 18 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index 24133528b8e9..a43514f624c0 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -18,7 +18,7 @@ soc {
>  		ranges;
>  
>  		gcr: system-controller@f0800000 {
> -			compatible = "nuvoton,npcm845-gcr", "syscon";
> +			compatible = "nuvoton,npcm845-gcr", "syscon", "simple-mfd";

This makes no sense. No children here.

>  			reg = <0x0 0xf0800000 0x0 0x1000>;
>  		};
>  
Best regards,
Krzysztof