Re: [PATCH 3/7] rust: debugfs: support for binary large objects

From: Alice Ryhl

Date: Sun Oct 19 2025 - 05:44:53 EST


On Fri, Oct 17, 2025 at 04:53:09PM +0200, Danilo Krummrich wrote:
> On Fri Oct 17, 2025 at 4:37 PM CEST, Danilo Krummrich wrote:
> > The reason I went with a trait is because that's consistent within the file.
> >
> > Otherwise, I don't mind one or the other. If we always want to use a struct, I'm
> > fine with that. :)
>
> Actually, there's another reason I forgot about since I sent the series. :)
>
> We need it because we derive it from blanket implementations:
>
> impl<T: BinaryWriter + Sync> BinaryReadFile<T> for T
> impl<T: BinaryReader + Sync> BinaryWriteFile<T> for T
> impl<T: BinaryWriter + BinaryReader + Sync> BinaryReadWriteFile<T> for T

You can still use a struct:

struct BinaryWriterVtable<T: BinaryWriter + Sync>;

impl<T: BinaryWriter + Sync> BinaryWriterVtable<T> {
const VTABLE: bindings::foo = ...;
}