RE: [PATCH] scsi:fnic: Self-assignment of intr_time_type has no effect

[Karan Tilak Kumar (kartilak)]

On Friday, October 17, 2025 12:55 AM, liuqiangneo@xxxxxxx <liuqiangneo@xxxxxxx> wrote:
>
>
> Remove the self-assignment statement of the intr_time_type variable
>
> Signed-off-by: Qiang Liu <liuqiang@xxxxxxxxxx>
> ---
> drivers/scsi/fnic/fnic_res.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/fnic/fnic_res.c b/drivers/scsi/fnic/fnic_res.c
> index 763475587b7f..9801e5fbb0dd 100644
> --- a/drivers/scsi/fnic/fnic_res.c
> +++ b/drivers/scsi/fnic/fnic_res.c
> @@ -134,7 +134,6 @@ int fnic_get_vnic_config(struct fnic *fnic)
> c->luns_per_tgt));
>
> c->intr_timer = min_t(u16, VNIC_INTR_TIMER_MAX, c->intr_timer);
> -     c->intr_timer_type = c->intr_timer_type;
>
> /* for older firmware, GET_CONFIG will not return anything */
> if (c->wq_copy_count == 0)
> --
> 2.43.0
>
>

Looks good to me. Thanks for the change.

Reviewed-by: Karan Tilak Kumar <kartilak@xxxxxxxxx>

Regards,
Karan