Re: [PATCH 1/2] dt-bindings: sound: qcom,sm8250: add QRB2210 and RB1 soundcards

[Alexey Klimov]

On Thu Oct 16, 2025 at 8:46 PM BST, Dmitry Baryshkov wrote:
> On Thu, 16 Oct 2025 at 18:08, Srinivas Kandagatla
> <srinivas.kandagatla@xxxxxxxxxxxxxxxx> wrote:
>>
>>
>>
>> On 10/7/25 2:26 AM, Alexey Klimov wrote:
>> > Add soundcard compatible for QRB2210 (QCM2290) platforms.
>> > While at this, also add QRB2210 RB1 entry which is set to be
>> > compatible with QRB2210 soundcard.
>> >
>> > Cc: Srinivas Kandagatla <srini@xxxxxxxxxx>
>> > Signed-off-by: Alexey Klimov <alexey.klimov@xxxxxxxxxx>
>> > ---
>> >  Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 5 +++++
>> >  1 file changed, 5 insertions(+)
>> >
>> > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
>> > index 8ac91625dce5ccba5c5f31748c36296b12fac1a6..c29e59d0e8043fe2617b969be216525b493458c4 100644
>> > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
>> > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
>> > @@ -21,6 +21,10 @@ properties:
>> >                - lenovo,yoga-c630-sndcard
>> >                - qcom,db845c-sndcard
>> >            - const: qcom,sdm845-sndcard
>> > +      - items:
>> > +          - enum:
>> > +              - qcom,qrb2210-rb1-sndcard
>> I don't think you need rb1 specific compatible here, unless there this
>> is totally different to what the base compatible can provide.
>
> Why do we need to deviate from other platforms which declare
> board-specific compat too?

There seems to be now a few incompatible suggestions for rb1 sndcard:
- make it compatible/fallback to qcom,sm8250-sndcard (1);
- make it compatible/fallback to qcom,qrb4210-rb2-sndcard (2);
- add separate compatible/enum for rb1 sndcard as qcom,qrb2210-rb1-sndcard (3);
- add base compatible as qcom,qrb2210-sndcard and fallback
rb1 sndcard compatible to it.

The latter one is ruled out because base compatible should be used and
it is not going to.

As far as I can see the last addition went simply with (3).
Which one finally you all want?

Best regards,
Alexey