Re: [PATCH v2] nfsd: Use MD5 library instead of crypto_shash

From: Chuck Lever
Date: Thu Oct 16 2025 - 14:32:00 EST


From: Chuck Lever <chuck.lever@xxxxxxxxxx>

On Thu, 16 Oct 2025 11:15:34 -0700, Eric Biggers wrote:
> Update NFSD's support for "legacy client tracking" (which uses MD5) to
> use the MD5 library instead of crypto_shash. This has several benefits:
>
> - Simpler code. Notably, much of the error-handling code is no longer
> needed, since the library functions can't fail.
>
> - Improved performance due to reduced overhead. A microbenchmark of
> nfs4_make_rec_clidname() shows a speedup from 1455 cycles to 425.
>
> [...]

Applied to nfsd-testing, thanks!

Note that the posted version of this patch does not apply cleanly to
the nfsd-testing branch here:

https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/log/?h=nfsd-testing

Be sure to rebase on that branch when posting subsequence patches
that target NFSD.

[1/1] nfsd: Use MD5 library instead of crypto_shash
commit: 4a8d4b1d4b8abcc0d73b924d4d15828dd2ead301

--
Chuck Lever